test: split lease integration tests by behavior (Phase 2)#46
Merged
Conversation
Move 36 lease integration scenarios into acquire, hooks, release, repair, and destroy files so Vitest can parallelize across workers. Shared cleanup and failOnceHook live in lease-integration helper.
Point agent guidance at split lease-*.integration.test.ts files and drop unrelated oxfmt-only changes in state-v1 and transitions tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 of the test speedup plan: split monolithic
lease.integration.test.tsinto behavior-oriented files so Vitest can parallelize lease scenarios across workers.lease-acquire.integration.test.tslease-hooks.integration.test.tslease-release.integration.test.tslease-repair.integration.test.tslease-destroy.integration.test.tsShared helpers in
helpers/lease-integration.ts(registerLeaseIntegrationCleanup,failOnceHook).No assertion or behavior changes — move-only refactor.
Timing (local)
Wall time is similar on this machine (already fast post-Phase 1), but the critical-path serial lease file is gone — lease files now run across
maxWorkers: 2. Main win is parallel ownership and clearer test boundaries.Test plan
pnpm check— 147 tests passFollow-up