Parameterize the negative signature tests across all ML-DSA parameter sets - #2
Merged
ffang merged 1 commit intoAug 21, 2026
Merged
Conversation
… sets Converts the tampered-SignatureValue and wrong-public-key rejection tests on both the DOM/JSR-105 and StAX paths from single hardcoded ML-DSA-65 cases to @ParameterizedTest/@CsvSource across ML-DSA-44/65/87, matching the style of the existing sign-and-verify tests. The StAX helper takes the signature and key algorithms as parameters instead of hardcoding ML-DSA-65.
This was referenced Aug 21, 2026
Owner
|
Thanks @Arpan0995 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on apache#645: this converts the tampered-SignatureValue and wrong-public-key tests on both the DOM/JSR-105 and StAX paths to
@ParameterizedTest/@CsvSourceacross ML-DSA-44/65/87, in the same style as the existing sign-and-verify tests. The StAX helper now takes the signature and key algorithms as parameters instead of hardcoding ML-DSA-65. The happy-path tests are untouched.Verified locally on this branch:
mvn test -Dtest=XMLSignatureMLDSATest,StaxMLDSASignatureTest -P bouncycastle: 9 + 9 executions, 0 failuresbouncycastleprofile: compiles and all 18 executions skip via the existingassumeTrueguards