Parameterize the negative encryption tests across all ML-KEM parameter sets - #3
Merged
ffang merged 1 commit intoAug 21, 2026
Conversation
…r sets Converts the wrong-recipient-key and truncated-encapsulation rejection tests on both the DOM and StAX paths from single hardcoded ML-KEM-768 cases to @ParameterizedTest/@CsvSource across ML-KEM-512/768/1024, matching the style of the existing encrypt-decrypt tests. The encryptToRecipient helpers take the key encapsulation algorithm as a parameter instead of hardcoding ML-KEM-768.
This was referenced Aug 21, 2026
Owner
|
Thanks @Arpan0995 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on apache#645: this converts the wrong-recipient-key and truncated-encapsulation tests on both the DOM and StAX paths to
@ParameterizedTest/@CsvSourceacross ML-KEM-512/768/1024, in the same style as the existing encrypt-decrypt tests. TheencryptToRecipienthelpers now take the key encapsulation algorithm as a parameter instead of hardcoding ML-KEM-768. The happy-path tests are untouched.The truncate-to-half corruption stays shorter than
encapsulationSize()for every parameter set (404/564/804 bytes against 768/1088/1568), so the length check inKeyUtils#kemDecapsulateis exercised by all three cases.Verified locally on this branch:
mvn test -Dtest=XMLEncryptionMLKEMTest,StaxMLKEMEncryptionTest -P bouncycastle: 9 + 12 executions, 0 failuresbouncycastleprofile: compiles and all 21 executions skip via the existingassumeTrueguards