feat: support coroutine functions as invoke targets#611
Merged
Conversation
Coroutine functions passed as invoke targets were silently broken: the coroutine was never awaited and the coroutine object was passed as data in the done.invoke event. Now the async engine detects coroutine callbacks and IInvoke handlers with async run() and awaits them directly on the event loop instead of routing through run_in_executor. Also adds InvalidDefinition when async IInvoke handlers are used with the sync engine, and ignores the local specs/ directory. Signed-off-by: Fernando Macedo <fgmacedo@gmail.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #611 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 42
Lines 5027 5027
Branches 812 812
=========================================
Hits 5027 5027
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #610.
datain thedone.invokeeventcallback._iscoro) and IInvoke handlers withasync def run()(_has_async_run()) and awaits them directly on the event loop instead of routing throughrun_in_executorInvalidDefinitionis raised when async IInvoke handlers are used with the sync engine (raw coroutine functions already auto-select the async engine via the callback detection pipeline)specs/directory in.gitignore