This repository was archived by the owner on Aug 31, 2022. It is now read-only.
rm jQuery dependency and add plain JavaScript API#80
Open
janKollars wants to merge 1 commit intofilamentgroup:masterfrom
Open
rm jQuery dependency and add plain JavaScript API#80janKollars wants to merge 1 commit intofilamentgroup:masterfrom
janKollars wants to merge 1 commit intofilamentgroup:masterfrom
Conversation
Refactoring of the code to remove jQuery as a dependency and introduction of a plain JavaScript API - Add `snapper` function to window which takes the carousel Elements as first parameter - Add tests for JS API - Add documentation of the available events and methods for the JS and jQuery API Closes filamentgroup#1
Author
|
I do not like how I duplicated the tests for the two APIs. Can you see a better solution? |
Author
|
The code formatting is quite awful, sorry. Do you have linter rules which I can apply? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring of the code to remove jQuery as a dependency and introduction of a plain JavaScript API
snapperfunction to window which takes Elements as first parameterCloses #1