chore(ci): install Pillow so CI can run PIL-based icon tests - #5
Merged
Merged
Conversation
tests/test_assets_and_icons.py imports PIL for icon/asset assertions but the CI install line only had `requirements.txt pytest ruff` -- CI was red on master for this reason (unrelated to the icon-fix content). Same root cause and fix as doc-bricks/CleanMarkdown.
|
Welcome! Thanks for your first pull request in this repository. A maintainer will review it soon. Please make sure:
Thanks for contributing. |
Collaborator
Author
|
Review (merge-reviewer, claude-opus) auf Head 1321f58: Die Änderung ist korrekt und minimal (Pillow in CI und im test-Extra). Damit ist der Sammelfehler
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kleiner Fix, wie von Team-Lead angefragt: CI war auf
masterrot, weiltests/test_assets_and_icons.pyPILimportiert, die CI-Install-Zeile aber nurrequirements.txt pytest ruffenthielt — nicht bedingt durch den Icon-Fix (#4), sondern vorbestehend. Gleicher Root Cause und Fix wie bei doc-bricks/CleanMarkdown..github/workflows/ci.yml:Pillowzur pip-install-Zeile ergänzt.pyproject.toml:Pillow>=10.0als optionaletest-Abhängigkeit ergänzt.Keine funktionale Änderung an App-Code, Icons oder Version.