Skip to content

fix(tests): platform-safe os.startfile/subprocess.Popen mock #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukisch merged 1 commit into from
Sep 26, 2026
Merged

fix(tests): platform-safe os.startfile/subprocess.Popen mock #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion tests/test_preview_panel_hardening.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,12 +147,22 @@ def test_metadata_handles_negative_or_invalid_timestamp_gracefully(self, tmp_pat

class TestExcelPreviewExternalLaunch:
def test_open_extern_handles_os_error_gracefully(self, tmp_path):
"""_open_extern() waehlt den Aufruf je nach sys.platform (os.startfile
unter Windows, subprocess.Popen("open"/"xdg-open") sonst) -- os.startfile
existiert unter Linux/macOS gar nicht, patch() darauf wuerde dort mit
AttributeError abbrechen. Der passende Aufrufpfad fuer die aktuelle
Plattform wird stattdessen gemockt."""
from gui.preview.preview_panel import ExcelPreview

widget = ExcelPreview()
widget._path = str(tmp_path / "fake.xlsx")

with patch("os.startfile", side_effect=OSError("No application associated")):
if sys.platform == "win32":
target, kwargs = "os.startfile", {"side_effect": OSError("No application associated")}
else:
target, kwargs = "subprocess.Popen", {"side_effect": OSError("No application associated")}

with patch(target, **kwargs):
widget._open_extern()

assert not widget.status_label.isHidden()
Expand Down
Loading