Skip to content

fix(batch-rename): recognize case-only self-rename on case-insensitive FS #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukisch merged 1 commit into from
Sep 26, 2026
Merged

fix(batch-rename): recognize case-only self-rename on case-insensitive FS #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/core/batch_rename_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,9 +236,23 @@ def generate_preview(
norm_target = os.path.normcase(os.path.abspath(item.new_path))
norm_src = os.path.normcase(os.path.abspath(item.original_path))

# Case-Only Rename der eigenen Datei ist zulässig
# Case-Only Rename der eigenen Datei ist zulässig. os.path.normcase()
# allein reicht dafür nicht: normcase folgt der Pfad-STRING-Konvention
# des Betriebssystems (Windows -> lowercase, POSIX -> No-Op) und weiß
# nichts über das tatsächliche Dateisystem. Unter macOS ist die
# Pfadkonvention case-sensitiv (normcase verändert nichts), das dort
# standardmäßige APFS aber case-insensitiv -- "sample.txt" und
# "SAMPLE.txt" sind auf Dateisystemebene dieselbe Datei, obwohl ihre
# normcase-Strings sich unterscheiden. os.path.samefile() vergleicht
# dagegen tatsächliche Inode/Device-Identität und erkennt das korrekt.
if norm_target == norm_src:
continue
if os.path.exists(item.new_path) and os.path.exists(item.original_path):
try:
if os.path.samefile(item.new_path, item.original_path):
continue
except OSError:
pass

# Ziel wird von einer anderen, nicht wegziehenden Batch-Datei blockiert
if norm_target in blocked_original_paths:
Expand Down
Loading