Skip to content

Combined patches - #36

Open
GoldenShit233 wants to merge 25 commits into
filloax:masterfrom
GoldenShit233:combined-patches
Open

Combined patches#36
GoldenShit233 wants to merge 25 commits into
filloax:masterfrom
GoldenShit233:combined-patches

Conversation

@GoldenShit233

Copy link
Copy Markdown

No description provided.

Added BitSet128 class with methods for getting, setting, and string representation.
Added return type annotation for RenderToWorld function.
Add GetColorParams function to Entity class.
Added a new function to retrieve the modded character's menu background sprite.
Added a Clear method to the GridEntitiesSaveStateVector class.
Add StatHUDPlanetarium field to Options.lua
Change MissingCharacter parameter type to integer
Add return type for GetRandomPool function
Add SetLastPool method to ItemPool class
Implement GetColorParams method in Entity.lua
Add return type to RenderToWorld function
Add return types to MakeGroundPoof function
Update overload documentation for SalvageCollectible
Refactor ColorParams function parameters
Change parameter type from ColorModifier to Color
Add GetModdedMenuBackgroundSprite function
Add Clear method to GridEntitiesSaveStateVector
@Ignatz-dev

Copy link
Copy Markdown
Contributor

Great work! Smart branch setup. From the looks of it you make 1 branch per file you change, and then merge all those back into a separate branch that you then submit in the PR... Is that so? I'm curious as I want to learn!

@GoldenShit233

Copy link
Copy Markdown
Author

Haha, not really 😭 I just ended up making a separate branch for each patch, and after doing this so many times it started to feel kind of abstract lol.

Then I just merged them all into combined-patches so I could submit them together.

@Ignatz-dev

Copy link
Copy Markdown
Contributor

I see. Well that's still a smart solution! It allows you to control each patch separately. I was doing all my stuff on main branch until now, and it ended up being a problem when I saw you have a patch here that I had on my end locally... and I needed to revert it without changing any other of my patches. I'm gonna be using your idea from now on :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants