Skip to content

bring up-to-date with denigma #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rpatters1 merged 1 commit into from
Aug 3, 2025
Merged

bring up-to-date with denigma #792

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions src/document_options_to_musescore.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,15 +583,17 @@ function write_marking_prefs(style_element)
log_message("unable to load FCCategoryDef for dynamics", true)
end
local font_info = finale.FCFontInfo()
local override = cat:GetMusicFontInfo(font_info) and font_info.IsSMuFLFont and font_info.FontID ~= 0
set_element_text(style_element, "dynamicsOverrideFont", override)
if override then
set_element_text(style_element, "dynamicsFont", font_info.Name)
set_element_text(style_element, "dynamicsSize", font_info.Size / default_music_font.Size)
else
set_element_text(style_element, "dynamicsFont", default_music_font.Name)
set_element_text(style_element, "dynamicsSize",
font_info.IsSMuFLFont and (font_info.Size / default_music_font.Size) or 1)
if cat:GetMusicFontInfo(font_info) then
local is_smufl = font_info.IsSMuFLFont
local override = is_smufl and font_info.FontID ~= 0
set_element_text(style_element, "dynamicsOverrideFont", override)
if override then
set_element_text(style_element, "dynamicsFont", font_info.Name)
set_element_text(style_element, "dynamicsSize", font_info.Size / default_music_font.Size)
elseif #music_font_name > 0 then
set_element_text(style_element, "dynamicsFont", music_font_name)
set_element_text(style_element, "dynamicsSize", font_info.Size / default_music_font.Size)
end
end
local font_pref = finale.FCFontPrefs()
if not font_pref:Load(finale.FONTPREF_TEXTBLOCK) then
Expand Down Expand Up @@ -624,7 +626,7 @@ function write_marking_prefs(style_element)
write_category_text_font_pref(style_element, "dynamics", finale.DEFAULTCATID_DYNAMICS)
write_category_text_font_pref(style_element, "expression", finale.DEFAULTCATID_EXPRESSIVETEXT)
write_category_text_font_pref(style_element, "tempo", finale.DEFAULTCATID_TEMPOMARKS)
write_category_text_font_pref(style_element, "tempoChange", finale.DEFAULTCATID_EXPRESSIVETEXT)
write_category_text_font_pref(style_element, "tempoChange", finale.DEFAULTCATID_TEMPOALTERATIONS)
write_line_prefs(style_element, "tempoChange", smart_shape_prefs.LineWidth, smart_shape_prefs.LineDashLength, smart_shape_prefs.LineDashSpace, "dashed")
write_category_text_font_pref(style_element, "metronome", finale.DEFAULTCATID_TEMPOMARKS)
set_element_text(style_element, "translatorFontFace", font_info.Name)
Expand All @@ -634,10 +636,10 @@ function write_marking_prefs(style_element)
write_default_font_pref(style_element, "repeatLeft", finale.FONTPREF_REPEAT)
write_default_font_pref(style_element, "repeatRight", finale.FONTPREF_REPEAT)
write_font_pref(style_element, "frame", font_info)
write_category_text_font_pref(style_element, "textLine", finale.DEFAULTCATID_TECHNIQUETEXT)
write_category_text_font_pref(style_element, "systemTextLine", finale.DEFAULTCATID_EXPRESSIVETEXT)
write_category_text_font_pref(style_element, "glissando", finale.DEFAULTCATID_TECHNIQUETEXT)
write_category_text_font_pref(style_element, "bend", finale.DEFAULTCATID_TECHNIQUETEXT)
write_font_pref(style_element, "textLine", font_info)
write_font_pref(style_element, "systemTextLine", font_info)
write_font_pref(style_element, "glissando", font_info)
write_font_pref(style_element, "bend", font_info)
write_font_pref(style_element, "header", font_info)
write_font_pref(style_element, "footer", font_info)
write_font_pref(style_element, "copyright", font_info)
Expand Down
Loading