This repository was archived by the owner on Dec 4, 2023. It is now read-only.
modify deleteObject behaviour so it does't fail when key is not present#109
Open
manuelcueto wants to merge 1 commit intofindify:masterfrom
Open
modify deleteObject behaviour so it does't fail when key is not present#109manuelcueto wants to merge 1 commit intofindify:masterfrom
manuelcueto wants to merge 1 commit intofindify:masterfrom
Conversation
rtvlad
reviewed
Feb 20, 2019
rtvlad
left a comment
rtvlad
left a comment
There was a problem hiding this comment.
LGTM. Only noting that the NoSuchKeyException case should also be removed from DeleteObjects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aws java sdk delete object function is successful if the key is not present. This pr attempts to change the behaviour of the mock deleteObject function to do the same.