chore(firestore-bigquery-export): improve fs-bq-schema-views when bigQueryID is invalid (rebased)#2782
Draft
IzaakGough wants to merge 2 commits intonextfrom
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves error handling in the gen-schema-view script by providing more descriptive messages for invalid BigQuery Project IDs and removes the onStartResize event from the storage-resize-images extension. Key feedback includes addressing a redundant configuration parsing call that could cause duplicate prompts, improving error logging by avoiding JSON.stringify on Error objects, and ensuring the process exits with a failure code on error. Additionally, the removal of event triggers should be synchronized with the event definitions in extension.yaml to maintain consistency.
IzaakGough
changed the title
…ssage when projectIds are invalid
IzaakGough
force-pushed
the
rebased-@invertase/improve-invalid-projectid-err-msg
branch
from
cb558ba to
baa730a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2540
supersedes #2594