Skip to content

feat(firestore): add support for isType pipeline expression#7985

Merged
dlarocque merged 10 commits intomainfrom
dl/type
Mar 31, 2026
Merged

feat(firestore): add support for isType pipeline expression#7985
dlarocque merged 10 commits intomainfrom
dl/type

Conversation

@dlarocque
Copy link
Copy Markdown
Contributor

Adds support for isType pipeline expression.

Ported from: googleapis/java-firestore#2329

Adds support for `isType` pipeline expression.

Ported from: googleapis/java-firestore#2329
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@dlarocque dlarocque requested review from milaGGL and yvonnep165 March 27, 2026 14:26
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@dlarocque
Copy link
Copy Markdown
Contributor Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the isType Pipeline expression to Firestore, allowing users to verify the data type of fields or expressions within a pipeline. It also promotes several Pipeline-related APIs from Beta to stable by removing the @Beta annotation. The changes include new API methods, registration of the is_type function, and comprehensive integration tests. Review feedback identified a typo in the CHANGELOG's pull request reference and formatting issues in the KDoc documentation for the new isType method.

@dlarocque
Copy link
Copy Markdown
Contributor Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the isType Pipeline expression, allowing developers to check the data type of fields or expressions. The changes include updates to the API definition, the function registry, and the addition of comprehensive unit tests. I have provided a suggestion to improve type safety and developer experience by replacing the string-based type parameters with a structured constant object.

milaGGL
milaGGL previously approved these changes Mar 28, 2026
Copy link
Copy Markdown
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment

@dlarocque dlarocque requested a review from milaGGL March 31, 2026 18:55
Copy link
Copy Markdown
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlarocque dlarocque merged commit 47a947e into main Mar 31, 2026
28 of 29 checks passed
@dlarocque dlarocque deleted the dl/type branch March 31, 2026 18:56
@github-actions github-actions bot mentioned this pull request Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants