Detect changes in AB Testing (ABT) experiment metadata during config fetch#8002
Open
athiramanu wants to merge 2 commits intomainfrom
Open
Detect changes in AB Testing (ABT) experiment metadata during config fetch#8002athiramanu wants to merge 2 commits intomainfrom
athiramanu wants to merge 2 commits intomainfrom
Conversation
Updated to detect changes in AB Testing (ABT) experiment metadata. This ensures that if an experiment's variant or affected parameter keys change, the associated config keys are correctly identified as changed, even if the parameter values remain the same. Key changes: - Added constant to . - Implemented in to map affected config keys to their respective experiment descriptions. - Modified to compare experiment metadata for each config key. - Updated with cases for changed, deleted, and key-shifted experiments.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
athiramanu
requested review from
ashish-kothari,
dsjadaun-google and
tusharkhandelwal8
| JSONArray affectedKeys = experiment.getJSONArray(AFFECTED_PARAMETER_KEYS); | ||
| for (int j = 0; j < affectedKeys.length(); j++) { | ||
| String key = affectedKeys.getString(j); | ||
| JSONObject experimentsCopy = new JSONObject(experiment.toString()); |
There was a problem hiding this comment.
Is this copy really required? We can reuse the same JSONObject to be added in the map
dsjadaun-google
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to detect changes in AB Testing (ABT) experiment metadata. This ensures that if an experiment's variant or affected parameter keys change, the associated config keys are correctly identified as changed, even if the parameter values remain the same.
Key changes:
Validation:
Testing on sample Android app: Link