Skip to content

[FR] Allow custom attributes on built-in traces (#6664) #8228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jrodiz wants to merge 6 commits into
base: main
Choose a base branch
from
+42 −0
Open

[FR] Allow custom attributes on built-in traces (#6664) #8228

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c2ae529
Allow custom attributes on built-in traces via global attribute API
jrodiz Apr 7, 2026
5e4bcb7
Remove redundant attribute merging
jrodiz May 14, 2026
ecdd8c1
Update CHANGELOG entry to reflect attribute-attachment location
jrodiz May 14, 2026
7f45e37
Version bump
jrodiz May 14, 2026
b78c655
Update CHANGELOG.md (#8175)
tejasd May 15, 2026
9a926c3
Address PR #8167 comments: revert @hide removal pending API review
jrodiz May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions firebase-perf/src/test/java/com/google/firebase/perf/transport/TransportManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1102,6 +1102,48 @@ public void syncLogForGaugeMetric_performanceDisabled_noInteractionWithFirebaseI

// region Global Custom Attributes Behaviour

@Test
public void logBuiltInTraces_globalCustomAttributesAreAdded() {
FirebasePerformance.getInstance().removeAttribute("experiment_id");
FirebasePerformance.getInstance().removeAttribute("user_tier");
FirebasePerformance.getInstance().putAttribute("experiment_id", "exp_123");
FirebasePerformance.getInstance().putAttribute("user_tier", "gold");

// 1. App Start Trace (_as)
TraceMetric appStartTrace = createValidTraceMetric().toBuilder().setName("_as").build();
testTransportManager.log(appStartTrace);
fakeExecutorService.runAll();
PerfMetric loggedAppStart = getLastLoggedEvent(times(1));
assertThat(loggedAppStart.getApplicationInfo().getCustomAttributesMap())
.containsEntry("experiment_id", "exp_123");
clearLastLoggedEvents();

// 2. Screen Trace (_st_MainActivity)
TraceMetric screenTrace =
createValidTraceMetric().toBuilder()
.setName("_st_MainActivity")
.putCounters(Constants.CounterNames.FRAMES_TOTAL.toString(), 100L)
.build();
testTransportManager.log(screenTrace);
fakeExecutorService.runAll();
PerfMetric loggedScreenTrace = getLastLoggedEvent(times(1));
assertThat(loggedScreenTrace.getApplicationInfo().getCustomAttributesMap())
.containsEntry("user_tier", "gold");
clearLastLoggedEvents();

// 3. Network Request
NetworkRequestMetric networkMetric = createValidNetworkRequestMetric();
testTransportManager.log(networkMetric);
fakeExecutorService.runAll();
PerfMetric loggedNetworkMetric = getLastLoggedEvent(times(1));
assertThat(loggedNetworkMetric.getApplicationInfo().getCustomAttributesMap())
.containsEntry("experiment_id", "exp_123");

// Cleanup
FirebasePerformance.getInstance().removeAttribute("experiment_id");
FirebasePerformance.getInstance().removeAttribute("user_tier");
}

@Test
public void logTraceMetric_globalCustomAttributesAreAdded() {
FirebasePerformance.getInstance().putAttribute("test_key1", "test_value1");
Expand Down
Loading