feat(core): add util method for fetching active scenes by selector - #16398
feat(core): add util method for fetching active scenes by selector#16398daymxn wants to merge 5 commits into
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
Generated by 🚫 Danger |
Per b/534816940,
This PR adds a common util method to
FirebaseCorefor finding an active scene that responds to a specific selector.With our recent scene delegate migration work, we've ran across a few instances where we needed to iterate over the connected scenes in the application and find one that responses to a certain selector.
There's some additional nuance to how we perform this search (ie; with
UISceneActivationStateForegroundInactive), which are worth documenting in a central place, and can easily be overlooked.To avoid this issue, and to practice proper DRY principles, we expose a central method in
FirebaseCorethat handles this process. Pending scene delegate work PRs should also be updated to take advantage of this method after it's merged.Tests have also been added for this new util method, and documentation articulating its usage and such have been added as well.
Example usage: