Skip to content

test(functions): address PR feedback and fix test timeouts - #16426

Draft
ncooke3 wants to merge 1 commit into
mainfrom
nc.functions.tests
Draft

test(functions): address PR feedback and fix test timeouts#16426
ncooke3 wants to merge 1 commit into
mainfrom
nc.functions.tests

Conversation

@ncooke3

@ncooke3 ncooke3 commented Jul 21, 2026

Copy link
Copy Markdown
Member
  • Refactored IntegrationTests.swift to use 'defer { expectation.fulfill() }' so that test failures correctly trigger XCTFail instead of causing obscure 10-second timeouts.
  • Updated FunctionsStreamTests availability to macOS 12.0 and watchOS 8.0, and removed '#if !os(watchOS)' to resolve watchOS test failures.
  • Wrapped agents.md intro to 80 chars and added a learning about preventing timeout masking in XCTest.

#no-changelog

- Refactored IntegrationTests.swift to use 'defer { expectation.fulfill() }' so that test failures correctly trigger XCTFail instead of causing obscure 10-second timeouts.
- Updated FunctionsStreamTests availability to macOS 12.0 and watchOS 8.0, and removed '#if !os(watchOS)' to resolve watchOS test failures.
- Wrapped agents.md intro to 80 chars and added a learning about preventing timeout masking in XCTest.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant