Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates reactfire to version ^4.3.0 and removes the custom firebase dependency override in package.json. The feedback highlights an issue in package-lock.json where several development dependencies, including @parcel/watcher, had their "dev": true flag removed, promoting them to production. It is recommended to regenerate the lockfile to restore their development status and avoid bloating production builds.
jhuleatt
marked this pull request as ready for review
November 2, 2026 16:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
reactfirefrom^4.2.1(locked at4.2.3) to^4.3.0, which also upgradesrxfirefrom6.1.0to6.3.0.Relevant changes since 4.2.1
peerDependenciesnow accept Firebase 10 through 13 (#713, #841), sopackage.jsonno longer needsoverrides.reactfireforfirebase@^10.7.1.useObservablesubscribes through React 18'suseSyncExternalStore(#583), closing the gap between render and effect commit foruseFirestoreDocanduseFirestoreCollection.SuspenseSubjectdisables its cache-reset timer whensuspense: true(#525), whichDocumentPreviewandCollectionboth pass. Slow initial Firestore queries will no longer reset the subject before the component mounts.useFirestoreDocDataomits the"NO_ID_FIELD"sentinel key when called without options (#738), as inFirestoreEmulatedApiProvider.test.tsxandDocumentPreview/index.test.tsx.