Skip to content

make local builds respect "ignore" files when uploading the built output#10438

Draft
falahat wants to merge 11 commits into
mainfrom
local_builds_ignore_files
Draft

make local builds respect "ignore" files when uploading the built output#10438
falahat wants to merge 11 commits into
mainfrom
local_builds_ignore_files

Conversation

@falahat
Copy link
Copy Markdown
Contributor

@falahat falahat commented Apr 30, 2026

Description

We already respect the "ignore" entry in firebase.json for source deploys and we want to do the same for local builds.

One crucial difference. For local builds, we apply this filter AFTER the build, on the built output. We can not prevent files from being included in the build.

Scenarios Tested

  • Test a local build with an ignore file
  • Manually inspect the uploaded content

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the ignore pattern logic in src/deploy/apphosting/util.ts by centralizing it into a new resolveIgnorePatterns function, which is now utilized by both createLocalBuildTarArchive and createSourceDeployArchive. Additionally, it introduces unit tests to ensure that ignore patterns from configuration and .gitignore files are correctly respected. Feedback includes a recommendation to avoid using 'as any' in test files to comply with the repository's style guide and a suggestion to remove the export keyword from the new utility function if it is only intended for internal use.

Comment thread src/deploy/apphosting/util.spec.ts Outdated
Comment thread src/deploy/apphosting/util.ts Outdated
@wiz-9635d3485b
Copy link
Copy Markdown

wiz-9635d3485b Bot commented May 12, 2026

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings 3 Medium
Software Management Finding Software Management Findings -
Total 3 Medium

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

Comment thread src/deploy/apphosting/prepare.ts
Comment thread src/deploy/apphosting/prepare.ts
Comment thread src/deploy/apphosting/prepare.ts
Comment thread src/deploy/apphosting/deploy.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants