Skip to content

chore: remove abort-controller polyfill#10456

Open
gameroman wants to merge 2 commits intofirebase:mainfrom
gameroman:remove-abort-controller
Open

chore: remove abort-controller polyfill#10456
gameroman wants to merge 2 commits intofirebase:mainfrom
gameroman:remove-abort-controller

Conversation

@gameroman
Copy link
Copy Markdown

Description

Removes abort-controller polyfill

Scenarios Tested

Sample Commands

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the abort-controller polyfill from the project's dependencies and various source files. The review identifies that this change will cause runtime TypeError exceptions in src/apiv2.ts, src/emulator/auth/operations.ts, and src/emulator/taskQueue.ts because the native AbortSignal.reason property is read-only and cannot be manually assigned. The feedback recommends using the controller.abort(reason) method for cancellations and refactoring 'as any' type assertions to adhere to the repository's TypeScript style guide.

Comment thread src/apiv2.ts
Comment thread src/emulator/auth/operations.ts
Comment thread src/emulator/taskQueue.ts
@gameroman gameroman force-pushed the remove-abort-controller branch from 6be17af to 075a6c3 Compare May 6, 2026 10:55
@joehan
Copy link
Copy Markdown
Member

joehan commented May 6, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the abort-controller dependency in favor of native AbortController support. It refactors src/apiv2.ts, src/emulator/auth/operations.ts, and src/emulator/taskQueue.ts to remove manual monkey-patching of the AbortSignal and updates abort() calls to include a FirebaseError. I have no feedback to provide.

@gameroman gameroman force-pushed the remove-abort-controller branch from 075a6c3 to 0e11bc4 Compare May 6, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants