chore(fdc): Use service classes to fetch auth and appcheck instances

[aashishpatil-g]

Use service resolvers to get auth and app check parameters.

[gemini-code-assist]

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

[aashishpatil-g]

/gemini review

[gemini-code-assist]

Code Review

This pull request deprecates the explicit passing of FirebaseAuth and FirebaseAppCheck instances in the FirebaseDataConnect constructor and instanceFor method, transitioning to automatic internal handling via the FirebaseApp service registry. It also includes updated mocks and new tests to verify dynamic service discovery. Feedback was provided to update the class fields directly during transport initialization to ensure state consistency instead of relying on local variables.

[cynthiajoan]

This is a bit of changing the behavior. The previous is if auth and appcheck is not passed in, instantiate one and put that. The changed code will be, if auth and appCheck is not passed in, assign it with an already registered auth/appcheck instance. If they are not instantiated, it will still keep null.

But also the previous behavior doesn't config auth and appcheck after instantiated. What is the expected thing here?

[aashishpatil-g]

Reverted to the previous behavior.