Skip to content

feat(sql_connect): update websocket URL for GSLB soft stickiness - #18531

Open
dconeybe wants to merge 3 commits into
mainfrom
dconeybe/dataconnect/GslbStickiness
Open

feat(sql_connect): update websocket URL for GSLB soft stickiness#18531
dconeybe wants to merge 3 commits into
mainfrom
dconeybe/dataconnect/GslbStickiness

Conversation

@dconeybe

@dconeybe dconeybe commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Updates the WebSocket connection URL path for Cloud Data Connect to include the project ID and service ID, aligning with backend changes for GSLB soft stickiness. Also updates the unit tests to verify the URL format using a local HTTP server.

Highlights

  • GSLB Stickiness URL Update: Modified WebSocketTransport to include projectId and serviceId in the WebSocket URL path, changing the format to /ws/google.firebase.dataconnect.v1.ConnectorStreamService.Connect/$projectId/locations/$location/services/$serviceId.
  • Improved Test Coverage: Updated websocket_transport_test.dart to use a local HttpServer to intercept and validate the connection path, replacing the previous static host configuration.
Changelog
  • websocket_transport.dart
    • Added projectId and serviceId to the WebSocket connection URL path.
  • websocket_transport_test.dart
    • Configured a local HttpServer in setup to receive test connection requests.
    • Added WebSocketTransport URL Validation test group to assert that the transport connects using the correct URL path.
    • Migrated test teardown to use addTearDown in setUp.

@dconeybe dconeybe self-assigned this Aug 4, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

…art:64:80 - String literals shouldn't be concatenated by the '+' operator. Try removing the operator to use adjacent strings. - prefer_adjacent_string_concatenation
@dconeybe
dconeybe marked this pull request as ready for review August 6, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant