Skip to content

fix(CI): cherry-pick upstream minio download patch - #49

Merged
lorenzhs merged 1 commit into
release-24.0.0from
lorenz/orc-memory-pool-adapter
Sep 21, 2026
Merged

lorenzhs merged 1 commit into
release-24.0.0from
lorenz/orc-memory-pool-adapter

Conversation

@lorenzhs

@lorenzhs lorenzhs commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

Cherry-pick of apache#51326 to fix CI


Note

Low Risk
CI-only download path and supply-chain hardening; no runtime Arrow or library behavior changes.

Overview
CI MinIO installs now pull from GitHub releases because https://dl.min.io returns HTTP 410 (apacheGH-47908).

install_minio.sh switches download URLs for minio and mc to the GitHub release asset naming, pins the same release tags as before, and verifies SHA-256 against hardcoded checksums per platform-arch before installing. It also drops s390x from the supported arch map, hardens the arch lookup with ${archs[$arch]:-}, and adds a .exe suffix on Windows.

The Windows wheel test base image Dockerfile is updated the same way: curl -L to the matching GitHub release exe instead of dl.min.io.

Reviewed by Cursor Bugbot for commit ab9b415. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d4d0201. Configure here.

Comment thread cpp/src/arrow/adapters/orc/adapter.cc Outdated
@lorenzhs
lorenzhs force-pushed the lorenz/orc-memory-pool-adapter branch from d4d0201 to 718db43 Compare September 21, 2026 08:50
…ses URL (apache#51326)

MinIO download URLs return HTTP 410. They have been removed. Use the same
releases from the GitHub releases download URL instead.

Cherry-picked from apache/arrow 7e3b55a.
Only ci/scripts/install_minio.sh and the Windows wheel test dockerfile carry
over: this fork's .env and .github/workflows/cpp.yml have diverged from
upstream and reference no MinIO URLs, so they are left alone.

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@lorenzhs
lorenzhs force-pushed the lorenz/orc-memory-pool-adapter branch from 718db43 to ab9b415 Compare September 21, 2026 08:56
@lorenzhs lorenzhs changed the title fix(orc): route liborc allocations through the Arrow memory pool (FB-4148) GH-51327: [CI] Fetch MinIO from GitHub releases (dl.min.io returns 410) Sep 21, 2026
@lorenzhs lorenzhs changed the title GH-51327: [CI] Fetch MinIO from GitHub releases (dl.min.io returns 410) fix(CI): cherry-pick upstream minio download patch Sep 21, 2026
@lorenzhs
lorenzhs merged commit 3f6015f into release-24.0.0 Sep 21, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants