feat(cli): submit keyless job feedback #221
+731
−72
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,8 @@ describe('CLI compatibility aliases', { timeout: 30000 }, () => { | |
| scrape.handleScrapeCommand = print; | ||
| scrape.handleAllScrapeCommand = (_url, options) => print(options); | ||
| require('./dist/commands/parse').handleParseCommand = print; | ||
| require('./dist/commands/search').handleSearchCommand = print; | ||
| require('./dist/commands/feedback').handleEndpointFeedbackCommand = print; | ||
| require('./dist/commands/crawl').handleCrawlCommand = print; | ||
| require('./dist/commands/agent').handleAgentCommand = print; | ||
| process.argv = [process.execPath, ${JSON.stringify(cliPath)}, ...${JSON.stringify(args)}]; | ||
|
|
@@ -33,11 +35,49 @@ describe('CLI compatibility aliases', { timeout: 30000 }, () => { | |
| env: { | ||
| ...process.env, | ||
| FIRECRAWL_API_KEY: '', | ||
| FIRECRAWL_API_URL: '', | ||
| FIRECRAWL_NO_UPDATE_CHECK: '1', | ||
| }, | ||
| }); | ||
| } | ||
|
|
||
| testWithBuiltCli.each([ | ||
| { flags: [], sources: ['web'] }, | ||
| { flags: ['--api-key', 'fc-test-key'], sources: ['web', 'alexandria'] }, | ||
| { flags: ['--sources', 'news'], sources: ['news'] }, | ||
| ])('selects usable Search sources with $flags', ({ flags, sources }) => { | ||
| const result = run(['search', 'retry reference', ...flags]); | ||
| expect(result.status, result.stderr).toBe(0); | ||
| expect(JSON.parse(result.stdout).sources).toEqual(sources); | ||
| expect(result.stdout).not.toContain('AUTH_CHECK'); | ||
| }); | ||
|
|
||
| testWithBuiltCli.each([ | ||
| 'search', | ||
| 'scrape', | ||
| 'parse', | ||
| 'map', | ||
| 'Search', | ||
| 'Scrape', | ||
| 'Parse', | ||
| 'Map', | ||
| ])( | ||
| 'retains the authentication gate only for Map feedback: %s', | ||
| (endpoint) => { | ||
| const result = run([ | ||
| 'feedback', | ||
| endpoint, | ||
| '00000000-0000-4000-8000-000000000001', | ||
| '--rating', | ||
| 'good', | ||
| ]); | ||
| expect(result.status, result.stderr).toBe(0); | ||
| expect(result.stdout.includes('AUTH_CHECK')).toBe( | ||
| endpoint.toLowerCase() === 'map' | ||
| ); | ||
| } | ||
| ); | ||
|
|
||
| testWithBuiltCli( | ||
| 'sql preserves experimental aliases and execution options', | ||
| () => { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,32 @@ describe('CLI argv parsing', () => { | |
| const cliPath = resolve(process.cwd(), 'dist/index.js'); | ||
| const testWithBuiltCli = existsSync(cliPath) ? it : it.skip; | ||
|
|
||
| testWithBuiltCli( | ||
| 'describes substantive keyless evidence in feedback help', | ||
| () => { | ||
| const result = spawnSync( | ||
| process.execPath, | ||
| [cliPath, 'feedback', '--help'], | ||
| { | ||
| cwd: process.cwd(), | ||
| encoding: 'utf8', | ||
| } | ||
| ); | ||
| expect(result.status).toBe(0); | ||
| for (const field of [ | ||
| '--task', | ||
| '--assessment', | ||
| '--observations-file', | ||
| 'one-based position', | ||
| 'source_comparison', | ||
| 'one submission', | ||
| ]) { | ||
| expect(result.stdout).toContain(field); | ||
| } | ||
| expect(result.stdout).not.toContain('UTC day'); | ||
| } | ||
| ); | ||
|
|
||
| testWithBuiltCli('rejects invalid PDF page caps before scraping', () => { | ||
| for (const value of ['0', '10001', '2.5', '3pages']) { | ||
| const result = spawnSync( | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.