agent: drop the 0-credits wording on credit stops; release 1.25.2 - #300
Merged
Merged
Conversation
Failed runs are refunded, so the API reports creditsUsed 0 for a run that did work and hit its limit. Omit the figure unless it is positive. Bumps the version so the credit-limit handling from #299 ships. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Shadow auto-approve: would require human review. The PR fixes the credit-stop headline wording and adds a test, but the version bump releases new credit-limit behavior to npm/binaries; deciding to publish that behavior is a rollout decision needing human sign-off.
Fix all with cubic | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
creditsUsed: 0for a run that did real work. The figure is now omitted unless it is positive.1.25.1→1.25.2so the credit-limit handling merged in agent: show partial results when a run hits its credit limit #299 actually publishes (npm and binaries release on a version bump).Found while testing #299 against production: a 15-credit-cap run returned
creditsUsed: 0and the notice read as if nothing ran.Validation
creditsUsed: 0prints the headline without "used 0 credits".format:checkpass.🤖 Generated with Claude Code
Summary by cubic
Fixes the credit-stop notice on refunded runs: the API reports
creditsUsed: 0for a run that did work and hit its limit, so the notice now omits the figure unless it is positive. Bumps1.25.1→1.25.2so the credit-limit handling ships.creditsUsed: 0prints the headline without "used 0 credits".Written for commit 6ce6a01. Summary will update on new commits.