Skip to content

Fix to reapply hostapd after wifi wan removed#1857

Closed
xinnige wants to merge 1 commit into
firewalla:masterfrom
xinnige:fix/orange_world_wan
Closed

Fix to reapply hostapd after wifi wan removed#1857
xinnige wants to merge 1 commit into
firewalla:masterfrom
xinnige:fix/orange_world_wan

Conversation

@xinnige
Copy link
Copy Markdown
Contributor

@xinnige xinnige commented May 13, 2026

@j-sallyjin
Copy link
Copy Markdown

PR Review Summary

✅ What looks good

  • Detects EVENT_WPA_DISCONNECTED specifically on the Wi-Fi client interface.
  • Limits the behavior to APC-managed WLAN platforms.
  • Debounces repeated disconnect events with a single delayed reapply timer.
  • Uses the active config as the source of truth instead of constructing a partial hostapd-only change.

⚠️ Issues found

  • Linked issue found: firewalla/firecommit#7775, but GitHub API access failed with HTTP Error 404, so issue requirement verification is limited to the PR title/body and provided diff.

  • No blocking correctness, security, or networking issues found in the provided diff.

💡 Suggestions

  • Consider adding a guard before reapply to confirm hostapd/AP config is actually present, since the helper name/log says “hostapd is configured” but the code currently reapplies on any matching WPA disconnect.
  • Add regression coverage or a manual test note for: Wi-Fi WAN removal → WPA disconnect → hostapd/AP remains available after delayed reapply.
  • Consider clearing _hostapdReapplyTimer during plugin teardown if this plugin has a lifecycle cleanup hook.

Verdict

APPROVE


Repo: firewalla/firerouter
PR: #1857
Head SHA: 52c2022b5b92bce872252058e552714428863ad7
Checked at: 2026-05-13 13:18:46 CST

@xinnige xinnige marked this pull request as draft May 13, 2026 09:10
@xinnige xinnige closed this May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants