#10 added docs about how payment vendor side tip is handled + extend …#11
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to payment handling, especially around payments that include tips, and enhances logging for better traceability of payment requests and responses. It also updates documentation to explain how to handle tip scenarios and clarifies test and example code to reflect these changes.
Enhancements to payment handling and logging:
Utils.DumpToLoggermethod inUtils.csto accept the originalPayItemRequestand log both the requested and received amounts, including calculation and display of any included tip amount. The log output is now more structured and easier to read, especially for responses with multiple pay items. [1] [2] [3] [4]Utils.DumpToLoggerin payment examples (Program.csin bothHOWTO_01_Payment_csharpandHOWTO_08_pay_sign_issue_csharp) to pass the original payment request, ensuring that logs contain complete context for each payment. [1] [2]Documentation updates for tip handling:
HOWTO_01_Payment_csharp/README.MDexplaining how to handle payments where a tip is added by the payment vendor, including a flow example and explanation of how the tip is represented in the response.README.MDto reference the new documentation for handling payments with tips, specifically for the test case with code30000,50.Code and test clarifications: