-
Notifications
You must be signed in to change notification settings - Fork 80
Rollup boost shadow builder #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
6af04bd to
e32587d
Compare
crates/rollup-boost/src/proxy.rs
Outdated
| }); | ||
| } | ||
|
|
||
| // If the shadow builder is enabled, forward the request to the shadow builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this won't mirror engine_calls, because we do return there
|
Moved one part, for the other will add shadow builder client into FlashblocksService and will make proxying there, after sending call to the builder |
|
should we add to the docs? |
|
Has the alternative of having multiple remote builders been properly explored? The issue says
but why can't we control if something is a fallback or silent observer with flags/configuration? |
|
After discussing this with @akundaz we decided that it would be good to add
|
|
why not forward all methods in the proxy instead of adding the shadow builder to the server? just pure proxying to the shadow builder will be much simpler to reason about. maybe we can have disable / enable mirroring as a separate config I think in the current implementation the shadow builder mirroring is not considering the execution mode and there will be a difference in calls if the builder fails in health checks. |
Resolves #460