refactor(ai): Drive the assistant loop through the shared agents runner#187
Merged
Conversation
Code Review SummaryThis PR refactors the AI assistant's execution loop to use the 🚀 Key Improvements
💡 Minor Suggestions
|
The assistant's tool loop, step budget, and tool approval now run on the shared agents library instead of a bespoke loop, so this logic lives in one tested place used by both the assistant and the MCP server. Per-call tool approval, auto-run, suggestion parsing, and the hidden-context behavior are preserved.
nfebe
force-pushed
the
feat/agents-runner-adoption
branch
from
July 21, 2026 15:54
8e124bf to
d560b8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #182.
The assistant's tool loop, step budget, and tool approval move onto the shared whilesmartgo/agents library, so that logic lives in one tested place instead of a hand-rolled loop. The MCP server (#186) already exposes the same tools; both now run on the same runner. Auto-run, per-call approval, suggestion parsing, and the hidden-context split are preserved.
Note: #186 and this branch both touch the agents dependency version, so whichever merges second needs a trivial rebase.