feat(ui): Add routing-only hostnames to the domain form#84
Merged
Conversation
A domain can now carry hostnames that route to the deployment but are never issued a certificate, for a hostname whose TLS is terminated by an external proxy such as Cloudflare. They are entered separately from ordinary aliases, which continue to request certificates, so the two cases are not confused.
Code Review SummaryThis PR adds support for routing-only hostnames to the Domain configuration UI. This allows users to specify hostnames that route to a deployment without triggering certificate issuance, typically used when TLS is handled by an external provider like Cloudflare. 🚀 Key Improvements
💡 Minor Suggestions
|
| class="form-input" | ||
| placeholder="dashboard.example.com" | ||
| /> | ||
| <button type="button" class="remove-btn" @click="removeRouteOnly(index)"> |
There was a problem hiding this comment.
The remove button lacks an accessible label. Since it only contains an icon, screen readers won't be able to describe the action to users.
Suggested change
| <button type="button" class="remove-btn" @click="removeRouteOnly(index)"> | |
| <button type="button" class="remove-btn" @click="removeRouteOnly(index)" aria-label="Remove hostname"> | |
| <i class="pi pi-times" /> | |
| </button> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A domain can now carry hostnames that route to the deployment but are never issued a certificate, for a hostname whose TLS is terminated by an external proxy such as Cloudflare. They are entered separately from ordinary aliases, which continue to request certificates, so the two cases are not confused.
Pairs with the agent-side routing support: flatrun/agent#177.