refactor(ui): Remove the unused dashboards API client#86
Closed
nfebe wants to merge 1 commit into
Closed
Conversation
The dashboard endpoints ship as backend storage with no UI builder, a deliberate choice, but the frontend still carried a typed client and panel types for them that nothing imported. Their presence implied a dashboard UI existed. Removing them leaves the backend API untouched; a real client can be added alongside the UI if one is ever built.
Code Review SummaryThis PR removes unused dashboard-related API clients and TypeScript interfaces from the frontend. This is a maintenance refactor intended to align the frontend code with the current project scope, where dashboarding is a backend-only feature. 🚀 Key Improvements
|
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
Contributor
Author
|
Closing: the dashboards client this removes is unfinished scaffolding from the observability UI work (#82), not dead code. Building the dashboard view that consumes those endpoints instead of deleting the groundwork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from the observability work. The dashboard endpoints were shipped by flatrun/agent#174 as backend storage with no UI builder, a deliberate choice. The #148 review flagged that the frontend still carried a typed client and panel types for those endpoints that nothing imported, so their presence implied a dashboard UI existed (tracked as an item under Albacore #158).
Removing them leaves the backend API untouched; a real client can be added alongside the UI if a dashboard builder is ever built.