Detect VS Code bundled built-in extensions in ai_tools - #50768
Detect VS Code bundled built-in extensions in ai_tools#50768juan-fdz-hawa wants to merge 1 commit into
Conversation
Resolves #50705 The ide_plugins collector only scanned the user profile's extensions directory. GitHub Copilot Chat ships bundled inside the application from VS Code 1.130+ and the standalone marketplace extension is deprecated, so an actively-enabled Copilot returned zero rows. Scan application install directories for bundled extensions, covering both the macOS .app/Contents/Resources/app/extensions layout and the Windows/Linux resources/app/extensions layout. Display names are resolved from package.nls.json, and rows are deduped against the user-profile pass since VS Code gives the profile copy precedence.
|
@coderabbitai full review |
✅ Action performedFull review finished. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
WalkthroughThe VS Code family scanner now detects AI extensions bundled inside supported applications on macOS, Windows, and Linux. It searches platform-specific application layouts, reads extension manifests, resolves localized display names, and preserves profile-extension precedence. Manifest conversion and AI classification are centralized in a helper. Tests cover platform detection, metadata, localization, filtering, duplicate suppression, and temporary-home isolation. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #50768 +/- ##
==========================================
+ Coverage 68.35% 68.38% +0.02%
==========================================
Files 3957 3962 +5
Lines 254097 255027 +930
Branches 13530 13530
==========================================
+ Hits 173681 174390 +709
- Misses 64860 65033 +173
- Partials 15556 15604 +48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Resolves #50705
The ide_plugins collector only scanned the user profile's extensions directory. GitHub Copilot Chat ships bundled inside the application from VS Code 1.130+ and the standalone marketplace extension is deprecated, so an actively-enabled Copilot returned zero rows.
Scan application install directories for bundled extensions, covering both the macOS .app/Contents/Resources/app/extensions layout and the Windows/Linux resources/app/extensions layout. Display names are resolved from package.nls.json, and rows are deduped against the user-profile pass since VS Code gives the profile copy precedence.
Checklist for submitter
If some of the following don't apply, delete the relevant line.
Changes file added for user-visible changes in
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Input data is properly validated,
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters.Timeouts are implemented and retries are limited to avoid infinite loops
If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes
Testing
Added/updated automated tests
Where appropriate, automated tests simulate multiple hosts and test for host isolation (updates to one hosts's records do not affect another)
QA'd all new/changed functionality manually
For unreleased bug fixes in a release candidate, one of:
Database migrations
COLLATE utf8mb4_unicode_ci).New Fleet configuration settings
If you didn't check the box above, follow this checklist for GitOps-enabled settings:
fleetctl generate-gitopsfleetd/orbit/Fleet Desktop
runtime.GOOSis used as needed to isolate changesSummary by CodeRabbit
New Features
Bug Fixes