Add config support for overriding endpoint max request size - #50823
Add config support for overriding endpoint max request size#50823hmacr wants to merge 3 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (8)
🚧 Files skipped from review as they are similar to previous changes (7)
WalkthroughAdded 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@server/service/integration_core_test.go`:
- Line 17140: Update both subtests configuring deprecatedLimit near the existing
cfg.Osquery.MaxLogWriteBodySize assignments to also set
cfg.Osquery.MaxDistributedWriteBodySize = deprecatedLimit, ensuring the
distributed-write requests use the same overridden limit and retain the expected
successful response.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 01fd956d-986a-4963-ad64-0a548cac1cce
⛔ Files ignored due to path filters (1)
docs/Configuration/fleet-server-configuration.mdis excluded by!**/*.md
📒 Files selected for processing (8)
changes/40829-endpoint-request-size-overridescmd/fleet/serve.goserver/config/config.goserver/config/config_test.goserver/platform/endpointer/endpoint_utils.goserver/platform/endpointer/endpoint_utils_test.goserver/platform/http/request.goserver/service/integration_core_test.go
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #50823 +/- ##
==========================================
- Coverage 68.53% 68.43% -0.10%
==========================================
Files 3977 3972 -5
Lines 256142 255802 -340
Branches 13818 13637 -181
==========================================
- Hits 175535 175069 -466
- Misses 64985 65113 +128
+ Partials 15622 15620 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
@JordanMontgomery This is my second contribution to the project, would love to get feedback on this 😄 |
Related issue: Resolves #40829
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Testing
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Documentation
Bug Fixes