FLEXSIM-12564: Fix PreferredPath to avoid modifying grid passability#20
Open
stamboli-autodesk wants to merge 1 commit intorelease/25.0from
Open
FLEXSIM-12564: Fix PreferredPath to avoid modifying grid passability#20stamboli-autodesk wants to merge 1 commit intorelease/25.0from
stamboli-autodesk wants to merge 1 commit intorelease/25.0from
Conversation
Removed logic that set canGoRight, canGoLeft, canGoUp, and canGoDown flags on AStarNode objects during preferred path processing.
stamboli-autodesk
requested review from
JonahKendell,
jjordanl,
kavika-faleumu,
pradeepkumar-adsk and
vikram-bharti
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the
addPassagesToTablemethod inPreferredPath.cppby removing unused variables and redundant logic related to direction flags. The main focus is on streamlining the lambda function passed tovisitGridModelLineand cleaning up the code that sets directional movement flags.Code simplification and cleanup:
dx,dy,fromRow,fromCol,toRow,toCol) from the lambda function in the call togrid->visitGridModelLine, making the function signature cleaner and easier to maintain.canGoRight,canGoLeft,canGoUp, andcanGoDownflags onAStarNodebased on direction and position, as well as the relatedisStartandisEndchecks. This reduces complexity and potential maintenance issues.Fixes : A*Star grid bug with twoway preferred paths [FLEXSIM-12564]