Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/flipper/ui/actions/import.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ class Import < UI::Action
route %r{\A/settings\/import/?\Z}

def post
render_read_only if read_only?
contents = params['file'][:tempfile].read
export = Flipper::Exporters::Json::Export.new(contents: contents)
flipper.import(export)
Expand Down
2 changes: 2 additions & 0 deletions lib/flipper/ui/views/settings.erb
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
</div>
</div>

<% if write_allowed? %>
<div class="card">
<div class="card-header">
<h4 class="m-0">Import</h4>
Expand All @@ -51,3 +52,4 @@
</form>
</div>
</div>
<% end %>
24 changes: 23 additions & 1 deletion spec/flipper/ui/actions/import_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,12 @@
{ :csrf => token, 'csrf' => token, '_csrf_token' => token }
end

let(:path) { FlipperRoot.join("spec", "fixtures", "flipper_pstore_1679087600.json") }

describe "POST /settings/import" do
before do
flipper.enable :plausible
flipper.disable :google_analytics
path = FlipperRoot.join("spec", "fixtures", "flipper_pstore_1679087600.json")

post '/settings/import',
{
Expand All @@ -37,5 +38,26 @@
expect(last_response.status).to be(302)
expect(last_response.headers['location']).to eq('/features')
end

context "when in read only mode" do
before do
allow(flipper).to receive(:read_only?) { true }

post '/settings/import',
{
'authenticity_token' => token,
'file' => Rack::Test::UploadedFile.new(path, "application/json"),
},
'rack.session' => session
end

it 'returns 403' do
expect(last_response.status).to be(403)
end

it 'renders read only template' do
expect(last_response.body).to include('read only')
end
end
end
end