moqt: tighten a few over-detailed/historical comments#27
Merged
Conversation
pkg/moqt/ comments are already in good shape (tight, spec-cited godoc with no stale filename or symbol references), so this is a small pass: - wire/varint.go: drop the "previously relied on from quicvarint.NewReader" history note from NewByteReader, stating the contract directly. - session/conn.go: condense the PrioritizedSendStream status paragraph. - session/request.go: remove a speculative "add a code-taking variant" parenthetical from resetStream. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applied the same comment review as #26 (stale comments + compression) to
pkg/moqt/.Finding: unlike
pkg/relay/, this package is already in good shape — no stale filename/symbol references, no history notes, no pervasive verbosity. Its comments are tight, spec-cited godoc. So this is a deliberately small pass, not a sweep.Changes
wire/varint.go: drop the "previously relied on from quicvarint.NewReader" history note fromNewByteReader; state the no-look-ahead contract directly.session/conn.go: condense the over-longPrioritizedSendStreamstatus paragraph (keeps the key fact: no bundled adapter implements it yet, quic-go#437).session/request.go: remove a speculative "add a code-taking variant if a future caller needs it" parenthetical fromresetStream.Verified clean (no changes needed)
wire/codec,message/(params/filter/subgroup/…),track,uri,loc,msf, and the rest ofsession/— comments are accurate and appropriately scoped.draft-ietf-moq-*references match the pinned versions (transport-18 / loc-02 / msf-01).Test plan
go build ./pkg/moqt/...✅go vet ./pkg/moqt/...✅gofmt -l✅🤖 Generated with Claude Code