refactor(session): drop openStreamWith prepare callback#35
Merged
Conversation
openStreamWith existed only to slot Request-ID allocation between OpenStream and Marshal via a parameterless prepare func() hook. With just two callers (OpenRequest, openAllocRequest), the callback was pure indirection. Inline the open in each opener, allocate the ID as a plain statement after a successful open, and share the marshal/reset tail via writeFirst. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openStreamWithexisted only to slot Request-ID allocation betweenOpenStreamandMarshalvia a parameterlessprepare func()hook. With exactly two callers —OpenRequest(no prepare) andopenAllocRequest(prepare = allocate ID) — the callback was pure indirection.This removes
openStreamWith:OpenRequestandopenAllocRequesteach open the stream directly.openAllocRequestallocates the Request ID as a plain statement after a successful open (preserving the §10.1 guarantee that a failed open consumes no ID).writeFirsthelper.No behavior change; pure readability cleanup.
Test plan
go build ./...go test ./pkg/moqt/session/golangci-lint run pkg/moqt/session/🤖 Generated with Claude Code