Open
Conversation
ghost
requested a review
from 
ghost
self-assigned this
- created manufactureModel & client - added product-manufacturer to searchClient
- imported PaymentMethodClient - imported ManufactureClient
- changed shopware search to manufacturers instead of products in the list function from manufacturerClient
fkwakkenbos
force-pushed
the
feature/add-manufacturer-to-shopware-api
branch
from
6812e85 to
80cfe7a
Compare
fkwakkenbos
approved these changes
Dec 8, 2023
| use Flooris\ShopwareApiIntegration\Clients\ProductMediaClient; | ||
| use Flooris\ShopwareApiIntegration\Clients\PropertyGroupClient; | ||
| use Flooris\ShopwareApiIntegration\Clients\CalculatedTaxClient; | ||
| use Flooris\ShopwareApiIntegration\Clients\PaymentMethodClient; |
Contributor
There was a problem hiding this comment.
Wordt deze gebruikt? Ik zie voor de rest geen verwijzing naar de PaymentMethodClass in deze pull-request.
src/Clients/ManufactureClient.php
Outdated
|
|
||
| public function list($limit = 25, $page = 1): stdClass | ||
| { | ||
| return $this->getShopwareApi()->search()->products(limit: $limit, page: $page); |
Contributor
There was a problem hiding this comment.
Moet dit niet manufacturers zijn i.p.v. products ?
|
|
||
| public function baseUri(): string | ||
| { | ||
| return 'product-manufacturer'; |
Contributor
There was a problem hiding this comment.
Strange URI for the Manufacturer model...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes