fix(flow-php/postgresql): traverse every AST node through protobuf descriptors - #2648
Merged
Merged
Conversation
…scriptors - Traverser walks all message fields, writes replacements at any depth, supports NodeModifier::REMOVE_NODE - keyset pagination wraps UNION/INTERSECT/EXCEPT; new collate() expression - explain() wraps every explainable statement and rolls back ANALYZE; failed SAVEPOINT keeps the outer transaction - schema DDL emits the declared expressions, index WHERE and trigger WHEN; trigger functions resolve to the table's schema - Index::toSql() and Trigger::toSql() replace the duplicated emitters; ExpressionParser::normalizeNode() removed
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2648 +/- ##
============================================
+ Coverage 84.87% 84.92% +0.04%
+ Complexity 31275 31218 -57
============================================
Files 2123 2124 +1
Lines 89617 89374 -243
============================================
- Hits 76064 75900 -164
+ Misses 13553 13474 -79 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #xxx
Change Log
Added
flow-php/postgresql-collate()expression andCOLLATEsupport in the query builderflow-php/postgresql-NodeModifier::REMOVE_NODEremoves nodes from listsflow-php/postgresql-Index::toSql()andTrigger::toSql()Fixed
flow-php/postgresql- AST traversal visits every node and applies nested replacementsflow-php/postgresql- keyset pagination over UNION/INTERSECT/EXCEPT keeps the cursor conditionflow-php/postgresql-explain()never executes writes, ANALYZE is always rolled backflow-php/postgresql- schema DDL emits declared expressions, index predicates and trigger WHEN conditionsflow-php/postgresql- schema-qualified trigger functions no longer drift against the catalogflow-php/postgresql- a failed SAVEPOINT keeps the outer transaction usableChanged
flow-php/postgresql-ModificationContextancestors are messages and depth counts every message edgeflow-php/postgresql- extractors report nodes from every clause, in PostgreSQL walker orderflow-php/postgresql-ExplainModifierhandlesParseResultand rejects non-explainable statementsflow-php/postgresql- schema objects keep the declared text and compare through normalised keysRemoved
flow-php/postgresql-NodeVisitor::REMOVE_NODEflow-php/postgresql-ExpressionParser::normalizeNode()Deprecated
Security