fix(flow-php/postgresql): sql_query_tables() returns only relation names - #2649
Merged
Merged
Conversation
- new RelationCollector: skips FOR UPDATE OF names and CTE references (PostgreSQL scope rules) - DROP / COMMENT ON / SECURITY LABEL / ALTER EXTENSION targets reported - fixes false view dependency cycles and false view drops in schema diffs - upgrading.md: plain characters instead of typographic ellipses
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2649 +/- ##
============================================
+ Coverage 84.91% 84.93% +0.02%
- Complexity 31218 31264 +46
============================================
Files 2124 2125 +1
Lines 89374 89490 +116
============================================
+ Hits 75892 76009 +117
+ Misses 13482 13481 -1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Added
flow-php/postgresql-RelationCollectorvisitor collecting only relation referencesflow-php/postgresql-sql_query_tables()reports DROP / COMMENT ON / SECURITY LABEL / ALTER EXTENSION targetsFixed
flow-php/postgresql-sql_query_tables()no longer returns FOR UPDATE OF names and CTE referencesflow-php/postgresql- false circular view dependencies and false view drops in schema diffsChanged
Removed
Deprecated
Security