Skip to content

fix In method calculateMaxIterationsValue, Integer.parseInt does not handle NumberFormatException. Invalid loop expressions will cause crashes #4245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
panshaobin wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

fix In method calculateMaxIterationsValue, Integer.parseInt does not handle NumberFormatException. Invalid loop expressions will cause crashes #4245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...flowable-engine/src/main/java/org/flowable/engine/impl/cfg/DefaultInternalJobManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,15 @@
import org.flowable.job.service.impl.persistence.entity.SuspendedJobEntity;
import org.flowable.job.service.impl.persistence.entity.TimerJobEntity;
import org.flowable.variable.api.delegate.VariableScope;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

/**
* @author Tijs Rademakers
*/
public class DefaultInternalJobManager extends ScopeAwareInternalJobManager {

private static final Logger LOGGER = LoggerFactory.getLogger(DefaultInternalJobManager.class);

protected ProcessEngineConfigurationImpl processEngineConfiguration;

Expand Down Expand Up @@ -311,7 +315,11 @@ protected int calculateMaxIterationsValue(String originalExpression) {
List<String> expression = Arrays.asList(originalExpression.split("/"));
if (expression.size() > 1 && expression.get(0).startsWith("R")) {
if (expression.get(0).length() > 1) {
times = Integer.parseInt(expression.get(0).substring(1));
try {
times = Integer.parseInt(expression.get(0).substring(1));
} catch (NumberFormatException e) {
LOGGER.warn("Failed to parse max iterations value from expression: {}", originalExpression, e);
}
}
}

Expand Down