Skip to content

fix If the construction of the wrapped BufferedReader fails, is may not be closed properly. Moreover, the reader variable is declared within the try block and cannot be accessed in the finally block. #4248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
panshaobin wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −4
Open

fix If the construction of the wrapped BufferedReader fails, is may not be closed properly. Moreover, the reader variable is declared within the try block and cannot be accessed in the finally block. #4248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions ...le-engine/src/main/java/org/flowable/engine/impl/bpmn/behavior/ShellActivityBehavior.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,14 +146,11 @@ public static String convertStreamToStr(InputStream is) throws IOException {
Writer writer = new StringWriter();

char[] buffer = new char[1024];
try {
Reader reader = new BufferedReader(new InputStreamReader(is, StandardCharsets.UTF_8));
try (Reader reader = new BufferedReader(new InputStreamReader(is, StandardCharsets.UTF_8))) {
int n;
while ((n = reader.read(buffer)) != -1) {
writer.write(buffer, 0, n);
}
} finally {
is.close();
}
return writer.toString();
} else {
Expand Down
Loading