Skip to content

fix(runner): do not group a single task's output in CI #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jahvon merged 1 commit into from
Aug 27, 2026
Merged

fix(runner): do not group a single task's output in CI #448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions internal/runner/parallel/parallel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,13 @@ func handleExec(
}

parentTask := ctx.CurrentTask
if parentTask == nil {
// Group the run's output only when there is more than one task. GitHub log
// groups are always collapsed, so wrapping a single task's output hides the
// only thing worth reading behind a click, with no structure gained.
// EndGroup is guarded by the same condition rather than relying on the
// logger to ignore an unmatched call, so this is correct on older tuikit too.
groupOutput := parentTask == nil && len(execs) > 1
if groupOutput {
if tal, ok := logger.Log().(io.TaskAwareLogger); ok {
tal.BeginGroup(parent.Ref().String())
}
Expand All @@ -283,7 +289,9 @@ func handleExec(
parentTask.Children = append(parentTask.Children, tracker.Tasks()...)
} else {
if tal, ok := logger.Log().(io.TaskAwareLogger); ok {
tal.EndGroup()
if groupOutput {
tal.EndGroup()
}
tal.PrintTaskSummary(tracker.Tasks())
}
}
Expand Down
12 changes: 10 additions & 2 deletions internal/runner/serial/serial.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,13 @@ func handleExec(
}

parentTask := ctx.CurrentTask
if parentTask == nil {
// Group the run's output only when there is more than one task. GitHub log
// groups are always collapsed, so wrapping a single task's output hides the
// only thing worth reading behind a click, with no structure gained.
// EndGroup is guarded by the same condition rather than relying on the
// logger to ignore an unmatched call, so this is correct on older tuikit too.
groupOutput := parentTask == nil && len(execs) > 1
if groupOutput {
if tal, ok := logger.Log().(io.TaskAwareLogger); ok {
tal.BeginGroup(parent.Ref().String())
}
Expand All @@ -263,7 +269,9 @@ func handleExec(
parentTask.Children = append(parentTask.Children, tracker.Tasks()...)
} else {
if tal, ok := logger.Log().(io.TaskAwareLogger); ok {
tal.EndGroup()
if groupOutput {
tal.EndGroup()
}
tal.PrintTaskSummary(tracker.Tasks())
}
}
Expand Down
Loading