Repository navigation
fix(config): write durations as strings in JSON - #512
Merged
Merged
Conversation
`flow config get --output json` wrote defaultTimeout and
logRetention.maxAge as nanosecond integers, the encoding/json default for
time.Duration, while the config file and the published schema spell them
as duration strings ("5m0s"). Anything typed from the schema fails to read
a config once either is set; the Mochi desktop app stopped loading after
setting a timeout.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flow config get --output jsonwrotedefaultTimeoutandlogRetention.maxAgeas nanosecond integers (encoding/json's default fortime.Duration), while the config file and the published schema spell them as duration strings such as5m0s.ConfigandLogRetentionnow marshal those fields as duration strings; unset durations are still omitted, and amaxAgeof zero (no limit) stays0s. YAML is unchanged.