This repository was archived by the owner on Jul 11, 2022. It is now read-only.
Get the correct PlayButtonOverlayView object for bufferAnimate#195
Open
kasrinat wants to merge 1 commit intoflowplayer:masterfrom
Open
Get the correct PlayButtonOverlayView object for bufferAnimate#195kasrinat wants to merge 1 commit intoflowplayer:masterfrom
kasrinat wants to merge 1 commit intoflowplayer:masterfrom
Conversation
For bufferAnimate() to work, it needs to call startBuffering() and stopBuffering() on the right playBtn object. Tested the compiled swc on a custom player page. Please verify on your end.
Author
|
Hello, checking on the validity of this pull request on your end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For bufferAnimate() to work, it needs to call startBuffering() and
stopBuffering() on the right playBtn object. Tested the compiled swc on
a custom player page. Please verify on your end.