Repository navigation
refactor(ipc): remove unused git history channels and thumbnail event - #64
Merged
Merged
Conversation
git:commitFiles, git:fileAt and the recents:thumb event were leftovers from earlier versions of the History panel and the start screen. The panel now gets each commit's files from log and its changes from git:commitDiff, and the start screen reloads thumbnails whenever it shows, so nothing called them anymore. Their gitHistory functions are removed with them. The file-list checks they covered now run through log with files, so the shared git options and parser stay tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git:commitFiles, git:fileAt and the recents:thumb event were leftovers from earlier versions of the History panel and the start screen. The panel now gets each commit's files from log and its changes from git:commitDiff, and the start screen reloads thumbnails whenever it shows, so nothing called them anymore.
Their gitHistory functions are removed with them. The file-list checks they covered now run through log with files, so the shared git options and parser stay tested.