Skip to content

docs: processors: content-modifier: add otel_log_attributes context#2483

Merged
eschabell merged 1 commit intofluent:masterfrom
eschabell:erics_processors_content_modifier_fixes
Mar 20, 2026
Merged

docs: processors: content-modifier: add otel_log_attributes context#2483
eschabell merged 1 commit intofluent:masterfrom
eschabell:erics_processors_content_modifier_fixes

Conversation

@eschabell
Copy link
Collaborator

@eschabell eschabell commented Mar 19, 2026

Add the missing otel_log_attributes context to the OpenTelemetry
contexts table. Unlike the resource and scope contexts, this one
operates per log record rather than on shared group data. Update
the section intro text to reflect that distinction accurately.

Fixes #2482

Summary by CodeRabbit

  • Documentation
    • Updated content modifier processor documentation to clarify scope semantics for OpenTelemetry log-related contexts. Refined per-context descriptions to specify whether operations apply to individual records or shared data across record groups, including newly documented otel_log_attributes context.

@eschabell eschabell self-assigned this Mar 19, 2026
@eschabell eschabell requested a review from a team as a code owner March 19, 2026 18:17
@eschabell eschabell added waiting-on-review Waiting on a review from mainteners 5.0 labels Mar 19, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 19, 2026

Warning

Rate limit exceeded

@eschabell has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 22 minutes and 6 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0efb3595-f99b-4d26-96df-c1ecb1bd8d51

📥 Commits

Reviewing files that changed from the base of the PR and between f41353c and beeab48.

📒 Files selected for processing (1)
  • pipeline/processors/content-modifier.md
📝 Walkthrough

Walkthrough

This change updates documentation for the content modifier processor to clarify OpenTelemetry context scope semantics. It refines descriptions to distinguish between contexts operating on shared data across groups of records versus those operating per-record, and adds documentation for the otel_log_attributes context.

Changes

Cohort / File(s) Summary
OpenTelemetry Context Documentation
pipeline/processors/content-modifier.md
Refined scope semantics descriptions for OpenTelemetry log contexts, replaced blanket statement with per-context clarity, and added documentation for otel_log_attributes (per-record scope) alongside existing contexts (shared data scope).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • cosmo0920
  • patrick-stephens

Poem

🐰✨ A hop through docs so neat,
Where otel_log_attributes now greet,
Per-record whispers, shared data too,
Clarity blooms—our scope shines through! 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding the otel_log_attributes context to the content-modifier processor documentation.
Linked Issues check ✅ Passed The PR fulfills all coding requirements from issue #2482: adds otel_log_attributes to the documentation table with correct scope (Logs) and description (log-level attributes).
Out of Scope Changes check ✅ Passed All changes are directly related to the issue objectives; the documentation updates to clarify per-record vs shared data semantics are necessary supporting changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@eschabell
Copy link
Collaborator Author

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 19, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

  Add the missing otel_log_attributes context to the OpenTelemetry
  contexts table. Unlike the resource and scope contexts, this one
  operates per log record rather than on shared group data. Update
  the section intro text to reflect distinction accurately.

  Fixes fluent#2482

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell eschabell force-pushed the erics_processors_content_modifier_fixes branch from f41353c to beeab48 Compare March 19, 2026 18:36
@eschabell
Copy link
Collaborator Author

@patrick-stephens and @cosmo0920 ready for review!

@eschabell eschabell removed the waiting-on-review Waiting on a review from mainteners label Mar 20, 2026
@eschabell eschabell merged commit 12b0e84 into fluent:master Mar 20, 2026
8 checks passed
@eschabell eschabell deleted the erics_processors_content_modifier_fixes branch March 20, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: processors: content-modifier: new attributes, scope, and description update needed based on code work in March.

2 participants