docs: administration: monitoring: fix fluentbit_hot_reloaded_times metric type and unit#2492
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughDocumentation updates to the REST API monitoring table and Prometheus metrics definitions in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…tric type and unit
- Fix `fluentbit_hot_reloaded_times` metric type from `gauge` to `counter`
in the first Prometheus metrics table (reflects source change)
- Fix `fluentbit_hot_reloaded_times` unit from `seconds` to `times`
in the second metrics table
- Add `/api/v2/health` endpoint to the HTTP API endpoints table
- Update `/api/v2/reload` entry to document `405 Method Not Allowed`
response with `Allow: GET, POST, PUT` header for unsupported methods
Fixes fluent#2488
Signed-off-by: Eric D. Schabell <eric@schabell.org>
09c321b to
f3f3736
Compare
|
@patrick-stephens and @cosmo0920 ready for review! |
fluentbit_hot_reloaded_timesmetric type fromgaugetocounterin the first Prometheus metrics table (reflects source change fromcmt_gauge_createtocmt_counter_createinsrc/flb_metrics.c)fluentbit_hot_reloaded_timesunit fromsecondstotimesin the second metrics table/api/v2/healthendpoint to the HTTP API endpoints table/api/v2/reloadentry to document405 Method Not Allowedresponse withAllow: GET, POST, PUTheader for unsupported methodsFixes #2488
Summary by CodeRabbit
/api/v2health checks and reload operations with HTTP response codes and headers