docs: inputs: winevtlog: add render_event_as_text params and fix table formatting#2504
Conversation
…e formatting - Add render_event_as_text, render_event_text_key config parameters - Update render_event_as_xml description to match source - Convert config parameter table keys to lowercase to match source - Sort config parameter table alphabetically - Fix parameter references in prose and command line examples to use lowercase - Add "Render events as text" usage section with YAML and classic .conf examples Fixes fluent#2495 Signed-off-by: Eric D. Schabell <eric@schabell.org>
📝 WalkthroughWalkthroughThe documentation for the Windows Event Log input plugin configuration is updated to convert all parameter keys from PascalCase to snake_case format, add new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pipeline/inputs/windows-event-log-winevtlog.md (1)
22-22: Consider using "username" for consistency with parameter name.The parameter name is
remote.username(one word), but the description uses "user name" (two words). Using "username" in the description would be more consistent with the parameter naming.📝 Proposed fix for consistency
-| `remote.username` | Specify user name of remote access for Windows EventLog. | _none_ | +| `remote.username` | Specify username of remote access for Windows EventLog. | _none_ |🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pipeline/inputs/windows-event-log-winevtlog.md` at line 22, The description for the parameter remote.username uses "user name" (two words); update the description to use "username" (one word) to match the parameter naming and maintain consistency—locate the entry referencing remote.username in the Windows EventLog inputs doc and change the phrase "Specify user name of remote access for Windows EventLog." to use "username" instead (and scan for other occurrences of "user name" tied to remote.username to make the same change).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@pipeline/inputs/windows-event-log-winevtlog.md`:
- Line 22: The description for the parameter remote.username uses "user name"
(two words); update the description to use "username" (one word) to match the
parameter naming and maintain consistency—locate the entry referencing
remote.username in the Windows EventLog inputs doc and change the phrase
"Specify user name of remote access for Windows EventLog." to use "username"
instead (and scan for other occurrences of "user name" tied to remote.username
to make the same change).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 35f56668-8fe7-4433-98b3-5428b06bdd65
📒 Files selected for processing (1)
pipeline/inputs/windows-event-log-winevtlog.md
Fixes #2495
Summary by CodeRabbit