out_opensearch: keep AWS credential providers refreshable for SigV4 signing - #189
Merged
Merged
Conversation
Watson1978
force-pushed
the
fix_expired_sigv4_token
branch
2 times, most recently
from
September 11, 2026 04:48
2d7bae4 to
b788f97
Compare
kenhys
reviewed
Sep 11, 2026
…igning aws_credentials collapsed refreshable providers into a static Aws::Credentials snapshot, so requests kept being signed with an STS token that expires after 1 hour by default. Passing the provider itself as credentials_provider lets Aws::Sigv4::Signer fetch fresh credentials for every request. Passing refresh_credentials_interval as the STS duration_seconds (fluent#78) was reverted in fluent#108, so it is not revisited here. Fixes fluent#188 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978
force-pushed
the
fix_expired_sigv4_token
branch
from
September 11, 2026 06:18
b788f97 to
9f6a4a0
Compare
kenhys
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
assume_role_arn,aws_credentialscollapsed the refreshable provider into a staticAws::Credentialssnapshot, so SigV4 kept signing with the STS token after it expired (1 hour by default) and the cluster answered 403The security token included in the request is expireduntil the plugin was restarted.This keeps the provider object and passes it to the signer as
credentials_provider, soAws::Sigv4::Signerfetches fresh credentials for every request.Passing
refresh_credentials_intervalas the STSduration_seconds(#78) was reverted in #108, so that approach is not revisited here.Fixes #188
🤖 Generated with Claude Code